minerllabs / minerl

MineRL Competition for Sample Efficient Reinforcement Learning - Python Package
http://minerl.io/docs/
Other
711 stars 153 forks source link

Bug in data_pipeline #572

Closed sheng-han-zhang closed 3 years ago

sheng-han-zhang commented 3 years ago

Hi, There is a bug in current version(0.4.0) minerl about include_metadata. The following is a link to the position of bug.

https://github.com/minerllabs/minerl/blob/dev/minerl/data/data_pipeline.py#L129

If we want to get infor like success, we need to enable include_metadata. But in current version, this is controled by include include_monitor_data, which I think is a typo.

Regards, Shenghan

Miffyli commented 3 years ago

Nice catch! We would be happy to accept a PR that fixes this (I need to dash myself right now, so I do not have time to properly test the change) :)