search

minerva-ml / minerva-training-materials

Learn advanced data science on real-life, curated problems
https://neptune.ml/minerva
MIT License
48 stars 14 forks source link

Avoid empty solution functions unless necessary #24

Closed buus2 closed 6 years ago

buus2 commented 6 years ago

In some tasks we have to do nothing with solution function, however we can still see this empty function. I'd like to suggest to just erase this function (or, analogously, CONFIG), unless necessary.

kamil-kaczmarek commented 6 years ago

@buus2 @jakubczakon As far as I understand this is related to the solution function in the notebooks, correct?

buus2 commented 6 years ago

Correct.

jakubczakon commented 6 years ago

Done and waiting for PR to merge.

kamil-kaczmarek commented 6 years ago

@jakubczakon @buus2 Done.