minerva-ml / steppy-toolkit

Curated set of transformers that make your work with steppy faster and more effective :telescope:

MIT License

22 stars 9 forks source link

v0.1 Scalers #24

Closed bcottman closed 6 years ago

bcottman commented 6 years ago

Pull Request template

Code contributions

no unit tests no "pretty doc" SteppyScalers.py class Steppy_Scaley general Scaler call using ScalerDict supports AbsScaler MinMaxScaler Normalizer RobustScaler StandardScaler add two new scalers LambertScaler (slow, need to be speeded up, StandardScaler 8x faster) BoxCoxScaler and some usage notes.

All testing done with SteppyScaler-test.v01.ipynb

Each pull request should be provided with minimal description about its contents.

Read SteppyScaler-test.v01.ipynb

Based on feedback will continue

Thanks!

Jakub & Kamil,

core contributors to the minerva.ml

kamil-kaczmarek commented 6 years ago

Hi @bcottman,

Looks significant! Thank you for this. Let me go through this code and I will get back to you soon with feedback. After some iterations we will accept it :smile:

Thanks again!

bcottman commented 6 years ago

I sent it to find out if I was on right path. It stills needs work to include docstring and unit tests. I guess you would call the notebook functional and integration testing.

So yes , will need few iterations

Regards Bruce

On Aug 30, 2018, at 7:08 AM, Kamil A. Kaczmarek notifications@github.com wrote:

Hi @bcottman,

Looks significant! Thank you for this. Let me go through this code and I will get back to you soon with feedback. After some iterations we will accept it 😄

Thanks again!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

bcottman commented 6 years ago

updated with doctoring and tested doctrines