search

minerva-ml / steppy-toolkit

Curated set of transformers that make your work with steppy faster and more effective :telescope:
MIT License
22 stars 9 forks source link

wrong cross entropy definition #3

Open kamil-kaczmarek opened 6 years ago

kamil-kaczmarek commented 6 years ago

cross_entropy function: https://github.com/minerva-ml/steppy-toolkit/blob/master/steppy_toolkit/pytorch/validation.py#L24 probably should be defined in a slightly different way:

def cross_entropy(output, target, squeeze=False):
    if squeeze:
        target = target.squeeze(1)
    return F.nll_loss(F.log_softmax(output), target)

Please verify.