search

mineshaftgap / d4m-nfs

Docker for Mac with NFS for performance improvements over osxfs
295 stars 26 forks source link

Eternal "Wait until D4M is running....." #3

Closed pensiero closed 7 years ago

pensiero commented 7 years ago

With the latest version of Docker for Mac beta (release Version 1.12.3-rc1-beta29 (13397)), when I start the script it says

Start and restop nfsd, for some reason restart is not as kind.
Stopping the nfsd service (use 'disable' to make permanent)
Starting the nfsd service
Wait until NFS is setup..
Wait until D4M is running......

and it never end. Docker for Mac is running. What could be?

brianvice commented 7 years ago

It seems that docker is registering it's running vmstate differently in newer beta releases? To remedy this issue for the time-being until the repo owner can address it you can comment out the lines that check to see if d4m is running. (line 46-50)

pensiero commented 7 years ago

Thanks @brianvice

pensiero commented 7 years ago

Should I leave this issue open?

brianvice commented 7 years ago

@pensiero The issue isn't really resolved I think. I don't know if it's necessary to check that the docker vm has started before continuing the script commands. Although It seems that since the script starts docker it is clear that it is running so another check might not be necessary. Just my two cents

I have noticed that this resolves my performance issues with docker native for macos. Thanks very much to the developer!

pensiero commented 7 years ago

Quote, it's incredibly fast now

brianvice commented 7 years ago

The issue isn't really resolved I think. I don't know if it's necessary to check that the docker vm has started before continuing the script commands. Although It seems that since the script starts docker it is clear that it is running so another check might not be necessary. Just my two cents

On 26 Oct 2016, at 14:13, Oscar Fanelli notifications@github.com wrote:

Should I leave this issue open?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

if-kenn commented 7 years ago

The reason you thought you could just comment it out was that D4M was probably already running and not being opened by d4f-nfs. So if it wasn't running already it probably wouldn't work.

I think I have made it D4M compatible with both stable and beta by running the miniscule docker image hello-world. You can delete this container, but if you do it will prevent d4m-nfs to be able to run offline.

Please let me know if this fixes your problem so if I can close this issue.

Thanks!

pensiero commented 7 years ago

YES! Now it works! Good job @if-kenn