search

minetest-LOTR / Lord-of-the-Test

LOTR-inspired Subgame for Minetest. Rewrite: https://github.com/minetest-LOTR/Third-Age
Other
67 stars 31 forks source link

Several enhancements #115

Closed Xaleth closed 7 years ago

Xaleth commented 7 years ago

fill_chest.lua is a work in progress.

Xaleth commented 7 years ago

This is very WIP because still not sure if it spawns in Iron Hills specifically because I haven't found one yet.

Xaleth commented 7 years ago

Minor changes with the spawning.

Xaleth commented 7 years ago

I added the latest version of WorldEdit compatible with 0.5.0 Minetest

Xaleth commented 7 years ago

Changed mapgen.lua

Xaleth commented 7 years ago

I'm done with attempting to make geomoria spawn in iron hills.

Feel free to make corrections.

Xaleth commented 7 years ago

Expect me to constantly update trader_goods.lua

Xaleth commented 7 years ago

Made chairs sittable upon rightclick.

Xaleth commented 7 years ago

You may now sleep in beds upon rightclick.

Xaleth commented 7 years ago

Question: Why am I not getting any feedback? I don't know whether geomoria is compatible with lottmapgen after all these commits. Is it? I'm sure you'll merge my commits on making the chairs sittable and beds sleepable. Anything else I should do?

Xaleth commented 7 years ago

To test my fork of your subgame just git clone my repository into your .minetest/games folder and test it.

Hello?

neinwhal commented 7 years ago

Hi, we are still thinking about it. (Abt geomoria) The issue is that, the current LOTT will be discontinued. A newer rebased, rebalanced, cleaner version will replace it, and the current version will be the last version to support the old LOTT, before the new one basically breaks everything.

We are unsure whether to add in something so major that might have bugs, as we want the final version to be as bugless as possible - as it will be the last one to support anyone who can't migrate over to the new LOTT - server owners/ players with a half developed world etc.

neinwhal commented 7 years ago

Also, it would be much better if you can split the changes into 4 different pull requests - beds, WE update, trader convo, geomoria. The 4 changes are very much different things, due to the reason above, geomoria is primarily blocking the other changes.

You can create separate branches in your repo, each of which is focused on a single change.

Xaleth commented 7 years ago

I removed geomoria from the mod collection for the time being. I'll work on it further.

You can merge my extra stuff.

neinwhal commented 7 years ago

Also you appeared to have removed WE.

Xaleth commented 7 years ago

I thought I only removed geomoria, I didn't know I also accidentally removed WE.

I will get WE 1.2 stable back here.

Xaleth commented 7 years ago

Satisfied the change requests.