search

minetest-LOTR / Lord-of-the-Test

LOTR-inspired Subgame for Minetest. Rewrite: https://github.com/minetest-LOTR/Third-Age
Other
67 stars 31 forks source link

LOTT: torches are visually broken #144

Closed FinishedFragment closed 4 years ago

FinishedFragment commented 5 years ago

torches are looking strange

normal torch orc torch

but they are emitting light correctly

ElonSatoshi commented 5 years ago

which version?

Amaz1 commented 5 years ago

No idea how to fix this, I think it's an engine bug. I'll change things back to 2d until the engine is fixed. Opened an issue in the engine :)

Amaz1 commented 5 years ago

If/when this is fixed in the engine, I'll revert d37b770 Keeping this open till then as a reminder.

kbpickens commented 4 years ago

I've created a fix for this in my repo. It creates Orc, Elf, and Human (basically default:torch, but it does not override default:torch) torches by replicating minetest_game's default:torch code, texture, and model and colorizing the nodes. I haven't seen any buildings created since I cloned the repo this morning (6 Jan 2020), but in 1.1.0 (downloaded 24 Nov 2019), the wall-mounted torches placed by lottmapgen stuck out horizontally.

These are angled out like minetest_game torches, not flat against the wall like the older LOTT torches.

Amaz1 commented 4 years ago

Another possible fix would be backporting this: https://github.com/minetest-LOTR/Lord-of-the-Test/commit/982e2eac4abc26be99203e3807eccfd9174febe8 It uses the MTG code, but with the old style of torches.

Amaz1 commented 4 years ago

Backported fix from rewrite-v2