Allow displaying image in POIs

minetest-mapserver / mapserver

Minetest realtime mapserver, written in go

Other

101 stars 22 forks source link

Allow displaying image in POIs #389

Closed Emojigit closed 5 months ago

Emojigit commented 5 months ago

This PR adds an image field to POIs. Works with minetest-mapserver/mapserver_mod#36

This PR is ready for review.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9691218951

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.636%

Totals
Change from base Build 9534112943:	0.0%
Covered Lines:	907
Relevant Lines:	1341

💛 - Coveralls

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9691350625

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.636%

Totals
Change from base Build 9534112943:	0.0%
Covered Lines:	907
Relevant Lines:	1341

💛 - Coveralls

BuckarooBanzay commented 5 months ago

good catch with the unsanitized url :+1:

this will make tracking of users that visit the poi-marker and open it possible, but i don't think that's an issue, if it is we can still hide it behind a configuration flag :shrug: