search

minetest-mods / 3d_armor

Visible player armor & wielded items for minetest
Other
17 stars 39 forks source link

forced depens on hunger api #64

Open mckaygerhard opened 3 years ago

mckaygerhard commented 3 years ago

the commit acd8b2647d1e840da26dc026ad6138e27d3dcd49 forces dependency of unnecesary hunger mod.. cos it uses reason that is only defined in hunger api..

so it breaks in other cases.. addition of another dependency is not a way

BuckarooBanzay commented 3 years ago

this only checks if the hunger field is nil on the reason variable, i don't see any depends on a mod there :/ Do you have an error/use-case i can work with?

mckaygerhard commented 3 years ago

it seems to work.. i have this commit backported in my fork.. i let open for now.. and close in few weeks.. (i am active now.. so dont worry)