search

minetest-mods / MoreMesecons

More mesecons items
https://forum.minetest.net/viewtopic.php?f=11&t=13150
Mozilla Public License 2.0
19 stars 12 forks source link

commandblock: don't allow sending colored text if server forbids it #28

Closed fluxionary closed 5 months ago

fluxionary commented 1 year ago

currently, players can get around the strip_color_codes setting by putting color escape sequences in a command block. this PR prevents that.

SmallJoker commented 1 year ago

I do not think that the use-case of strip_color_codes applies in this case. Command blocks are only triggered when there are people nearby, hence does not qualify as a regular chat command. Sending colors, such as in welcome messages or to improve readability should not be restricted.

fluxionary commented 1 year ago

Command blocks are only triggered when there are people nearby

sure, but the receiver doesn't have to be nearby, you can currently send messages to anyone on the server.

SmallJoker commented 1 year ago

Well ... that sucks

Bastrabun commented 9 months ago

For my reference 3922