search

minetest-mods / anvil

Minetest mod providing an anvil with which to repair worn tools
GNU General Public License v3.0
14 stars 18 forks source link

made screwdriver repairable by an anvil #33

Closed imre84 closed 8 months ago

fluxionary commented 1 year ago

looks good to me now, though as i'm not part of the "mintest-mods" org, i'm not sure what weight my approval has.

imre84 commented 1 year ago

looks good to me now, though as i'm not part of the "mintest-mods" org, i'm not sure what weight my approval has.

ok, thank you for your help, I guess we'll just need to wait for an official approval then :)

imre84 commented 1 year ago

technic:sonic_screwdriver is still able to rotate the anvil in weird ways, but given the fact that for some reason on_rotate isn't called when rotating with technic:sonic_screwdriver, and it's not a regression (normal screwdriver was doing the same before this PR) I'm going to live with that and not extend the scope of this PR

Niklp09 commented 1 year ago

@imre84 Merge conflict, rebase needed.

imre84 commented 1 year ago

@Niklp09 hello, currently I do not play minetest and I have other projects as well. The PR was made against the head of the master branch at the time though. Maybe I'll revert to minetest in the next two years, in that case maybe I'll update the PR.

imre84 commented 9 months ago

@imre84 Merge conflict, rebase needed.

Hello, conflict fixed

imre84 commented 7 months ago

should I have received an email when this was merged?