search

minetest-mods / castle

A fork of Dan's fork old my old castle mod. :P
Other
5 stars 7 forks source link

Converting castle into a modpack #34

Closed FaceDeer closed 7 years ago

FaceDeer commented 7 years ago

Here's the cumulation of the work I've been doing for the past few weeks. I've created a release on my fork, but I'm not sure if that'll carry through with this pull request. If not a new one will be need to be added after it's brought through.

I'll write up an update to the castle mod thread when this pull is finished and I've got a final location to link to for the mod's .zip file.

sofar commented 7 years ago

Yeah, good. I'd end up squashing this, though. Cheers.

:+1:

FaceDeer commented 7 years ago

Yeah, I guess that would simplify the git history significantly. :) Want me to squash it pre-merge, or should I leave this pull request be and let you do it once it's in?

sofar commented 7 years ago

There is a button for it, so you're fine to leave as-is.

FaceDeer commented 7 years ago

Okay. I get a bit timid when doing something with git that I've never done before, especially when it involves weeks of work.

Izzyb1234 commented 7 years ago

Something appears to be wrong with this commit. I did a git pull and now this mod produces errors indicating it can't find castle/ropes/init.lua. Seems all the castle subdirs are empty. I did a fresh clone and same problem. Not sure how to fix this.

VanessaE commented 7 years ago

It uses submodules, so git clone --recursive should help.

kaeza commented 7 years ago

If you have already cloned, you can use git submodule update --init.