Craftguide inventory graphical issue - Githubissues

minetest-mods / craftguide

:book: The most comprehensive Crafting Guide on Minetest

Other

43 stars 20 forks source link

Craftguide inventory graphical issue #102

Open orbea opened 4 years ago

orbea commented 4 years ago

minetest: 5.2.0 craftguide: https://github.com/minetest-mods/craftguide/commit/8c7408f66f0483ff064f004b29dc69de158b3a74

When using the craftguide book or sign the arrows are overlapping with the number of usages or recipes. While its still usable, its distracting and much harder to read unlike the screenshot shown in the README.md file.

I can reproduce this with minetest_game and no other mods, is there anything that can be done to resolve this?

kilbith commented 4 years ago

I'm waiting https://github.com/minetest/minetest/pull/8658 to be merged to fix that. Current label wrapping doesn't care about font size.

orbea commented 4 years ago

Ah, thanks for explaining. Do you know what the current delay with that PR is? Could it be potentially backported to a server build or is it client side?

kilbith commented 4 years ago

Both the server and client need it. Ask @rubenwardy for a review.

Wuzzy2 commented 4 years ago

Why not just giving the text more space to breathe in the meantime? Will also benefit translations which are usually more verbose than English.

kilbith commented 4 years ago

The proper fix is to have the label aligned on the right and put it outside between the buttons.

kilbith commented 4 years ago

Text has been granted more space (good if you're german) but this doesn't into account the font size yet.

kilbith commented 4 years ago

https://github.com/minetest-mods/craftguide/commit/00dcea5c50240e0ab50f1b97b55676e4a7d4f553 should resolve the labels overlapping but you need to use Minetest 5.4-dev.

orbea commented 4 years ago

Thanks for the continued attention, I'm not currently playing minetest so I'm not sure when I will be able to test this. Feel free to close this issue when you find best, I would suggest perhaps when this is fixed in a stable minetest release?