search

minetest-mods / craftguide

:book: The most comprehensive Crafting Guide on Minetest
Other
43 stars 20 forks source link

Multiple crashes while trying to use craftguide for the first time #108

Closed triffid closed 4 years ago

triffid commented 4 years ago

First time I ran minetest with craftguide added, it just went to grey screen and gave me this on my terminal when I clicked the 'crafting guide' button in the inventory's 'more' tab:

2020-04-16 20:58:39: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'sfinv' in callback on_playerReceiveFields(): /home/triffid/.minetest/mods/craftguide/init.lua:1120: attempt to get length of field 'items' (a nil value)
2020-04-16 20:58:39: ERROR[Main]: stack traceback:
2020-04-16 20:58:39: ERROR[Main]:       /home/triffid/.minetest/mods/craftguide/init.lua:1120: in function 'make_fs'
2020-04-16 20:58:39: ERROR[Main]:       /home/triffid/.minetest/mods/craftguide/init.lua:1712: in function 'on_use'
2020-04-16 20:58:39: ERROR[Main]:       /home/triffid/.minetest/mods/craftguide/init.lua:1783: in function 'action'
2020-04-16 20:58:39: ERROR[Main]:       ...e/triffid/.minetest/mods/minetest_sfinv_buttons/init.lua:137: in function <...e/triffid/.minetest/mods/minetest_sfinv_buttons/init.lua:114>
2020-04-16 20:58:39: ERROR[Main]:       ...iffid/Projects/minetest/bin/../builtin/game/register.lua:429: in function <...iffid/Projects/minetest/bin/../builtin/game/register.lua:413>
2020-04-16 20:58:39: ACTION[Server]: singleplayer leaves game. List of players:
2020-04-16 20:58:39: ACTION[Main]: Server: Shutting down
Quit message received.

Then I tried adding

craftguide_sfinv_only = true
craftguide_progressive_mode = true

to my minetest.conf

Then, it crashed to desktop when I clicked 'craft guide' tab in inventory:

2020-04-16 21:07:54: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'sfinv' in callback on_playerReceiveFields(): /home/triffid/.minetest/mods/craftguide/init.lua:543: attempt to get length of upvalue 'init_items' (a nil value)
2020-04-16 21:07:54: ERROR[Main]: stack traceback:
2020-04-16 21:07:54: ERROR[Main]:       /home/triffid/.minetest/mods/craftguide/init.lua:543: in function 'get_filtered_items'
2020-04-16 21:07:54: ERROR[Main]:       /home/triffid/.minetest/mods/craftguide/init.lua:1673: in function 'on_enter'
2020-04-16 21:07:54: ERROR[Main]:       ...triffid/.minetest/games/minetest_game/mods/sfinv/api.lua:139: in function 'set_page'
2020-04-16 21:07:54: ERROR[Main]:       ...triffid/.minetest/games/minetest_game/mods/sfinv/api.lua:179: in function <...triffid/.minetest/games/minetest_game/mods/sfinv/api.lua:159>
2020-04-16 21:07:54: ERROR[Main]:       ...iffid/Projects/minetest/bin/../builtin/game/register.lua:429: in function <...iffid/Projects/minetest/bin/../builtin/game/register.lua:413>
2020-04-16 21:07:54: ACTION[Server]: singleplayer leaves game. List of players:
2020-04-16 21:07:54: ACTION[Main]: Server: Shutting down
terminate called after throwing an instance of 'LuaError'
what():  Runtime error from mod 'craftguide' in callback on_shutdown(): /home/triffid/.minetest/mods/craftguide/init.lua:2017: attempt to index local 'meta' (a nil value)
stack traceback:
/home/triffid/.minetest/mods/craftguide/init.lua:2017: in function 'save_meta'
/home/triffid/.minetest/mods/craftguide/init.lua:2029: in function </home/triffid/.minetest/mods/craftguide/init.lua:2026>
...iffid/Projects/minetest/bin/../builtin/game/register.lua:429: in function <...iffid/Projects/minetest/bin/../builtin/game/register.lua:413>
Aborted

I've tried all four variations of the config options, and I always get one of these two crashes if I try to use craftguide.

I'm using current git head of everything (minetest 5cbe8437 (5.2.0), minetest_game 52c6921c, craftguide 5560374801, sfinv_buttons 4f3b075b60)

kilbith commented 4 years ago

Fixed: https://github.com/minetest-mods/craftguide/commit/109965175d64d06e82b9dd569d712de0629f967c

You should use releases to avoid crashes.