search

minetest-mods / craftguide

:book: The most comprehensive Crafting Guide on Minetest
Other
43 stars 20 forks source link

attempt to call field 'register_on_mods_loaded' (a nil value) #44

Closed ghost closed 5 years ago

ghost commented 5 years ago

Seems like this particular commit added the code

https://github.com/minetest-mods/craftguide/commit/b2a7f5430ace197e5eadb81e6b42ea133d4113a6#diff-d7d74284e2e39f6c06d199c8e2bedbd0R384

This causes a crash in current stable Minetest version 0.4.17.1 when on master branch of craftguide because minetest.register_on_mods_loaded is an upcoming 5.0.0 feature.

kilbith commented 5 years ago

Yes, this is why I warned the users about it on the forum topic: https://forum.minetest.net/viewtopic.php?p=338231#p338231

Although I should create a separate branch with some backports.

kilbith commented 5 years ago

Although I should create a separate branch with some backports.

Done: https://github.com/minetest-mods/craftguide/tree/0.4.17

ghost commented 5 years ago

Thanks, confirmed :)