search

minetest-mods / craftguide

:book: The most comprehensive Crafting Guide on Minetest
Other
43 stars 20 forks source link

Remove formspec background #49

Closed p-ouellette closed 5 years ago

p-ouellette commented 5 years ago

This doesn't change the background in MTG (except a slight difference in the border). For other games it will depend on what the formspec prepend is set as.

kilbith commented 5 years ago

Oops, didn't notice that. Fixed: https://github.com/minetest-mods/craftguide/commit/1def071029f3eacf09e93721dceb822afe0d472e

p-ouellette commented 5 years ago

That breaks formspec theming. Why shouldn't games be allowed to customize the background for consistency with other formspecs? At least move the background into the not sfinv block so there's no inconsistency when switching tabs.

kilbith commented 5 years ago

The sfinv tab keeps the minetest_game default background. I don't think there is a need for theming.

p-ouellette commented 5 years ago

Yes, and craftguide adds a background on top of the minetest_game background, so there's a slight difference in the border and color when you switch tabs. What if craftguide is used in a game that sets a yellow background instead of gray? Then there more inconsistency.

kilbith commented 5 years ago

there's a slight difference in the border and color when you switch tabs

Ah right, I'll fix that.

What if craftguide is used in a game that sets a yellow background instead of gray?

Then the game creator is stupid because some formspec elements (like buttons) are necessarily dark-ish because of Irrlicht. This will cause an inconsistency.

Or he could just edit the color in GIMP. No biggie.

p-ouellette commented 5 years ago

Image buttons could be used (like MineClone2). But if everyone does use the same dark grey background as MTG, why does craftguide need to override it with it's own almost identical background?

p-ouellette commented 5 years ago

Also set_formspec_prepend sets more than just the background. craftguide now has inconsistent tooltips.

kilbith commented 5 years ago

I deleted my comment for a reason, pauloue. Also there is no way to convince me otherwise, sorry. If the game creators want a different theme, they can do it in their forks.

p-ouellette commented 5 years ago

Sorry, didn't see that.