search

minetest-mods / craftguide

:book: The most comprehensive Crafting Guide on Minetest
Other
43 stars 20 forks source link

Digging recipe added for stone → cobblestone, but not for anything else #63

Closed Wuzzy2 closed 5 years ago

Wuzzy2 commented 5 years ago

There is a digging recipe for stone → cobblestone, but the craftguide ignores digging results for anything else. This does not make sense.

Either the craftguide should show all digging results, or none of them. Anything “in between” is inconsequent and weird.

kilbith commented 5 years ago

Without surprise, this is a custom recipe. Such recipes have to be collected manually.

p-ouellette commented 5 years ago

I don't think "digging" recipes make sense. Registered recipes should only involve items in a player's inventory. If "digging" is a valid crafting type, then e.g. monster--killing-->loot must be a valid recipe. Also if interacting with the world counts as a craft, then progressive mode doesn't make sense with these recipes since you don't need them in your inventory.

A better example of a custom craft type would be e.g. brewing or alloying.

kilbith commented 5 years ago

To be fair, this recipe was registered as a demo over all.

Wuzzy2 commented 5 years ago

I suggest to remove this “demo” (your own words) then and to put it as an example in the API docs somehow.

It should be up to mods and games to decide whether they consider “digging” a crafting recipe or not. I agree with paulone.

kilbith commented 5 years ago

https://github.com/minetest-mods/craftguide/commit/1f6de2a04f4de37e64ab17c9d418950fd911f93f