minetest-mods / craftguide

:book: The most comprehensive Crafting Guide on Minetest
Other
43 stars 20 forks source link

Replace group with item in item's usages #75

Closed p-ouellette closed 5 years ago

p-ouellette commented 5 years ago

My fix for #68. The current fix applies to the default filter only.

If a recipe qualifies as a usage of an item because it takes a group that the item matches, then the usage is shown with the item in place of the group. This allows filters to filter the recipe properly.

It also makes more sense because usages of an item should display that item. Otherwise if there are multiple group ingredients it may be unclear which of those groups the clicked item belongs to.

kilbith commented 5 years ago

https://github.com/minetest-mods/craftguide/commit/feaf43ed4763058bc8c21fc5ae2c8ed6448ce4a0

Thanks.