search

minetest-mods / craftguide

:book: The most comprehensive Crafting Guide on Minetest
Other
43 stars 20 forks source link

Some recipes not being shown #89

Closed ghost closed 4 years ago

ghost commented 4 years ago

In Hamlet's Quest mods are stored in subfolders, or modpacks.

In MT v0.4.17 everything was fine, now the craftguide isn't showing the recipes of some mods.

These are: anvil, handholds, breadcrumbs, sounding_line and ropes.

I have tried updating each and every mod's mod.conf, I have tried with the new modpack.conf, eventually I've discovered that moving player_api in the mods' root folder (../minetest/games/game/mods/) helped to show some more recipes (don't ask me why). I have also tried removing the hq_tweaks folder to be sure that no modifications done by me were interfering.

Eventually I tried moving every mod from the modpacks (../minetest/games/game/mods/modpack/) to the mods' root folder (../minetest/games/game/mods/), and the craftguide was correctly showing every recipe.

Until I tried the gravelsieve mod (which I had put in ../minetest/mods/), once again the recipe wasn't being shown.

Have you any idea why this could be possibly happening? I am getting crazy trying to figure where is the issue.

kilbith commented 4 years ago

Which commit are you on?

ghost commented 4 years ago

I was on https://github.com/minetest-mods/craftguide/commit/732535c9da279b9bd115f0f6cb6892bcf3406cbd (the one after https://github.com/minetest-mods/craftguide/issues/88); however I've downloaded the latest one and it fixed my game's issue.

Sill, there's something strange with the Gravelsieve mod: I have tried loading it on MTG v5.0.1 with the latest craftguide's version, and it isn't showing the sieve and auto_sieve recipes, but it is showing the compressed_gravel and the hammer recipes. ??? This is happening on a clean MT & MTG v5.0.1 installation.

Can you reproduce the issue?

kilbith commented 4 years ago

That's because there are aliases registered next after the craft declarations. This isn't good practice, however that should be fixable.

ghost commented 4 years ago

That's because there are aliases registered next after the craft declarations. This isn't good practice, however that should be fixable.

Ah, probably something that the mod's developer wasn't aware of - just like me! Let me know if you need help with testing, thank you in advance for looking into this.

kilbith commented 4 years ago

That should work now: https://github.com/minetest-mods/craftguide/commit/aef1fe0dc6863cff47312068a7519c9b03b8012f