minetest-mods / craftguide

:book: The most comprehensive Crafting Guide on Minetest
Other
43 stars 20 forks source link

sfinv_only mode does not work with progressive_mode #97

Closed bell07 closed 4 years ago

bell07 commented 4 years ago

sfinv_only mode does not work with progressive_mode

Steps to reproduce:

Result:

2020-01-22 07:54:37: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'sfinv' in callback on_playerReceiveFields(): /home/user/.minetest/mods/craftguide/init.lua:938: attempt to get length of field 'dat' (a nil value)
2020-01-22 07:54:37: ERROR[Main]: stack traceback:
2020-01-22 07:54:37: ERROR[Main]:   /home/user/.minetest/mods/craftguide/init.lua:938: in function 'get_panels'
2020-01-22 07:54:37: ERROR[Main]:   /home/user/.minetest/mods/craftguide/init.lua:1110: in function 'make_formspec'
2020-01-22 07:54:37: ERROR[Main]:   /home/user/.minetest/mods/craftguide/init.lua:1641: in function 'get_formspec'
2020-01-22 07:54:37: ERROR[Main]:   ...e/user/.minetest/games/minetest_game/mods/sfinv/api.lua:119: in function 'set_player_inventory_formspec'
2020-01-22 07:54:37: ERROR[Main]:   /home/user/.minetest/mods/craftguide/init.lua:1119: in function 'show_fs'
2020-01-22 07:54:37: ERROR[Main]:   /home/user/.minetest/mods/craftguide/init.lua:1625: in function 'fields'
2020-01-22 07:54:37: ERROR[Main]:   /home/user/.minetest/mods/craftguide/init.lua:1657: in function </home/belka/.minetest/mods/craftguide/init.lua:1656>
2020-01-22 07:54:37: ERROR[Main]:   /usr/share/minetest/builtin/game/register.lua:429: in function </usr/share/minetest/builtin/game/register.lua:413>
kilbith commented 4 years ago

This is fixed in https://github.com/minetest-mods/craftguide/commit/f9f99888680f3ac632e8806b086c12c43848b6d2

@pauloue can you double-check please? I believe I fucked things up with the progressive mode recently.