search

minetest-mods / digilines

Digilines is a mod for minetest which adds data bus wires
Other
40 stars 38 forks source link

change digiline to digilines in nodedef #47

Closed Desour closed 5 years ago

Desour commented 7 years ago

Finally fixes https://github.com/minetest-mods/digilines/pull/44#issuecomment-287105804.

numberZero commented 7 years ago

Acceptable. Another variant:

function digilines.getspec(node)
    local nodedef = minetest.registered_nodes[node.name]
    if not nodedef then return false end
    return nodedef.digilines or nodedef.digiline
 end
Desour commented 7 years ago

Your variant seems to be better since it saves some indexing.

Desour commented 7 years ago

To be reviewed/approved/merged.

Desour commented 6 years ago

This PR does not break anything, is simple, is not controversial and is already here in its current state for over a whole year. Other mods won't update their node specs until this here gets merged. I think, the maintaining of minetest-mods/digilines could be a little bit faster.

sofar commented 5 years ago

Next time, please ping me 30 days after a PR is considered ready for merge. I haven't had time to go through all the mods in a while and find these sort of ready-to-go prs and merge them.