search

minetest-mods / digilines

Digilines is a mod for minetest which adds data bus wires
Other
40 stars 38 forks source link

LCD appears broken #55

Open sofar opened 5 years ago

sofar commented 5 years ago

After all the merges, it appears the LCD no longer functions properly, and I don't understand why.

@numberZero @DS-Minetest

Desour commented 5 years ago

I can't find any problems at testing with a newly placed lcd. Could you describe the problem more precisely? Steps to reproduce would be helpful.

sofar commented 5 years ago

Old LCD displays no longer worked. All I did was hook up a chest to a LCD screen to quickly see if taking out/storing items produces the expected text.

Desour commented 5 years ago

Ah, I see. It's not the lcd that makes problems but the digiline chest. It now sends tables instead of strings.

Change from sending strings to sending tables.

49

This means that old constructions won't work anymore. I'm not sure if this really is a big problem. There might be some ugly and hacky ways to fix this, but reworks can break things, I think this is ok but players should be informed in some way.

(I'm sorry that I haven't spent again time to review that PR btw. >_<)

@Hawk777

Hawk777 commented 5 years ago

Ah, yes, that was my change, wasn’t it? Yes, it does unfortunately break existing builds, but I submitted it thinking that the improvement was worthwhile (IMO the old string-based message format simply didn’t give enough information to do some of the useful things with Digilines chests that people might want, and expanding the string-based format would break existing parsers anyway, so why not just switch to tables while we’re at it?). I didn’t realize people would directly connect a Digilines chest to an LCD without an intervening Luacontroller, and it’s true that doesn’t work any more.

As far as informing players, does Digilines have a news page, changelog, or something? I’m not a member of the Minetest forum; maybe that’s where the info is supposed to go?