LCDs: Rework line breaking algorithm, include spaces, show unknown symbols as spaces

PeterNerlich commented 4 years ago

This PR succeeds and replaces #62.

Typeset the lines according to these rules (in order of subjective significance):

words that fit on the screen but would let the current line overflow are placed on a new line instead
" | " always forces a linebreak
spaces are included, except when there is a linebreak anyway
words with more characters than fit on screen are just chopped up, filling the lines as full as possible
don't bother typesetting more lines than fit on screen
if we are on the last line that will fit on screen

PeterNerlich commented 3 years ago

Okay, but I only now notice the offset is still wrong. Let me try to find why...

PeterNerlich commented 3 years ago

Now it should work properly.

PeterNerlich commented 3 years ago

So this is how it looks now, nice and centered in every way (except vertically if there are less than the maximum number of lines – would that be preferrable to include, while I'm at it?)

screenshot_20201207_194317

Hawk777 commented 3 years ago

LGTM!

SmallJoker commented 3 years ago

No need to create more issues if your PR is about to be merged. Thanks to both of you.

minetest-mods / digilines

LCDs: Rework line breaking algorithm, include spaces, show unknown symbols as spaces #64