search

minetest-mods / digilines

Digilines is a mod for minetest which adds data bus wires
Other
40 stars 38 forks source link

Fix wires not connecting to nodes using the `digilines` definition #68

Closed OgelGames closed 3 years ago

OgelGames commented 3 years ago

Currently wires only connect to nodes using the deprecated digiline definition, this fixes that by also checking for the digilines definition.

Also updates all the nodes to use the correct definition.

Related: #44 #47

Desour commented 3 years ago

Oops, looks like I didn't test good enough in the other PR, sorry.

Use digilines.getspec(node).

OgelGames commented 3 years ago

@SmallJoker

OgelGames commented 3 years ago

digilines.getspec() takes both, digilines and digiline whereas latter seems to be deprecated (?).

Correct, however the code to connect wires was not using that function, and was only checking for the deprecated digiline definition.

https://github.com/OgelGames/digilines/commit/4b270a80db541dcbf3b93a7bed01abc45b9dcb77#diff-e4ed61d521245fb4b41a0479ab69838ff3f336be02b6ecdba287528f19d0d596L45-R42

I cannot see any difference. The Digiline Chest and RTC seem to connect just fine.

That is because they still use the deprecated digiline definition, which is also corrected in this PR.

If you change those to use digilines without adding the changes to the wire connecting, you will see they don't connect.