Send messages from digiline chest when items are moved with tubelib

minetest-mods / digilines

Digilines is a mod for minetest which adds data bus wires

Other

40 stars 38 forks source link

Send messages from digiline chest when items are moved with tubelib #73

Closed oversword closed 3 years ago

oversword commented 3 years ago

Fixes https://github.com/minetest-mods/digilines/issues/61 Sends the same events from tubelib interaction as would be sent from pipeworks

Moved the tube_can_insert and tube_insert_object callbacks out of the node definition so they can be re-used in the tubelib registration
Optionally required tubelib and registered callbacks for pushing and pulling
Used "speculative pull" variable to only send a "take" event if tubelib's unpull is not called after a pull - this happens when it tries to take an item but there is no room, so it fails

oversword commented 3 years ago

~~Might take a look at the possibility of implementing terumet too, forgot I put that in the issue~~ That looks like a no, it just injects the items directly, no callbacks to hook into

oversword commented 3 years ago

@Panquesito7 @OgelGames can I get some eyes and thumbs?

oversword commented 3 years ago

Just noticed this might be a bit more complex than expected, as I just remembered an unpull may effectively move the item, I also want this to work with whole stacks or it will be very difficult to make useful

oversword commented 3 years ago

Okay I re-wrote the callbacks so they act a little more predictably, should be good now

oversword commented 3 years ago

@SmallJoker can you accept the workflow and give this a review? (and maybe merge it :D)

SmallJoker commented 3 years ago

Thanks for the changes. I'll trust you on these changes because my knowledge about digilines is almost zero. The code looks good, and the parts that aren't quite nice were at least only moved, hence no problem.

Will merge in a few days unless there are objections.

oversword commented 3 years ago

Thanks for the changes. I'll trust you on these changes because my knowledge about digilines is almost zero

Thanks, mine too TBH, but I'm using the existing API for that so not my problem :P I have been working on tubelib/tehpack quite a lot though and am pretty certain it is working well with all the weirdnesses of that mod

the parts that aren't quite nice were at least only moved

I agree haha, switching between inline / side-by-side view you can see I haven't changed anything there. Maybe if you're (un)lucky I'll get round to a digilines re-write at some point, the APIs are so inconsistent every node needs its own instruction book

SmallJoker commented 3 years ago

I noticed that the pipeline was not run - this seems to happen for all first-time contributor's PRs now. Would you mind having a look at them?

oversword commented 3 years ago

@SmallJoker Of course, probably just linting. I think they're disabled because people realised they could mine cryptocurrency for free using github's computers by submitting "checks" that actually trigger full programs

oversword commented 3 years ago

@SmallJoker that should do it, run it again