search

minetest-mods / digilines

Digilines is a mod for minetest which adds data bus wires
Other
40 stars 38 forks source link

*hard* depends on default or mcl, not optionally #84

Open TheEt1234 opened 6 months ago

TheEt1234 commented 6 months ago

Game: devtest

ModError: Failed to load and run script from /home/et/.minetest/mods/digilines/init.lua:
/home/et/.minetest/mods/digilines/inventory.lua:172: attempt to index field 'sounds' (a nil value)
stack traceback:
    /home/et/.minetest/mods/digilines/inventory.lua:172: in main chunk
    [C]: in function 'dofile'
    /home/et/.minetest/mods/digilines/init.lua:88: in main chunk
Check debug.txt for details.

Problematic segment: https://github.com/minetest-mods/digilines/blob/master/inventory.lua#L172C11-L172C54

Solution: If no default mod then no sound

TheEt1234 commented 6 months ago

oh nevermind it's slightly different

if minetest.get_modpath("default") then digilines.sounds = default end
if digilines.mcl then digilines.sounds = mcl_sounds end

So it supports mineclone2 or default, nothing else i think that should be made clear as an error message or just default to no sound