search

minetest-mods / drawers

[MTG/MCL2] A Minetest Mod adding storage drawers in different sizes and wood types.
Other
19 stars 26 forks source link

fix crash with animated nodes (inventorycube related) #77

Closed Niklp09 closed 1 year ago

Niklp09 commented 1 year ago

tile_to_image function by HybridDog (LGPLv2.1+)

Fix for https://github.com/minetest-mods/drawers/issues/76 @lnjX

lnjX commented 1 year ago

We need to ask HybridDog for permission to use under MIT or relicense the mod to LGPL-2.1-or-later (which should be possible because MIT is LGPL compatible I think). And HybridDog needs to be credited in a copyright line (or a REUSE # SPDX-FileCopyrightText: line).

Niklp09 commented 1 year ago

@HybridDog

SmallJoker commented 1 year ago

Is this a general issue with core.inventorycube (i.e. flawed function)? If so, please open an issue on minetest/minetest so that it can be fixed.

lnjX commented 1 year ago

@SmallJoker The code expected that tiles is always a list of strings (which it isn't always). core.inventorycube() work fine. :)

(It would be nice though to have a function that takes tiles to create an inventorycube in the minetest core)

HybridDog commented 1 year ago

Yes, you can use my code under MIT. And it's also fine for me if you don't credit me for this function.