[BUG] Misc. settings don't save

minetest-mods / i3

:rocket: A next-generation inventory for Minetest 5.6+

Other

41 stars 26 forks source link

[BUG] Misc. settings don't save #64

Closed Beethoven-n closed 2 years ago

Beethoven-n commented 2 years ago

Describe the bug On changing the Misc. settings in the inventory and quitting the game, then re-entering, your settings are not saved.

To Reproduce

Open the i3 inventory
Change a Misc. setting
Quit the game
Re-enter the game on the world you played on Your settings will not be restored when you come back.

Additional context

Mod version? Release or git? Release
Engine version? 5.5.0
LuaJIT enabled? Yes
Operating system? Arch Linux
Did you try to disable other mods except i3? Yes

Comments Would it be a good idea to add a config file to read from for this?

kilbith commented 2 years ago

I'm aware and it is by design. These "settings" aren't meant to be saved accross sessions. Users are likely to change their inventory sorting preferences.

Beethoven-n commented 2 years ago

huh? why change sorting preferences?

ainola commented 2 years ago

It really is odd design, though. One tab saving the preferences while the other doesn't gives an impression like it's buggy, unintended behavior. I also find myself not wanting to turn off the auto-sorting as well. If I did I could always untick the box myself. :)

Would you reconsider this bug, @kilbith, or at least make some indication that the settings in that tab are temporary?

kilbith commented 2 years ago

Grab the latest release, the behavior has changed.

ainola commented 2 years ago

How serendipitous! Thanks for doing that.