Make craftable using recipe from Taose fork

minetest-mods / inspector

A minetest node inspector tool that shows various properties of nodes.

GNU Lesser General Public License v2.1

9 stars 8 forks source link

Make craftable using recipe from Taose fork #4

Closed minertestdude closed 4 years ago

minertestdude commented 5 years ago

This adds recipe for tool, so users can craft it.

[ ] collisions with other mods? [ ] issues like excessive data? (Taose fork provides limited reporting using additional privs)

thomasrudin commented 5 years ago

Can this be packaged with a setting (default: off)? I don't think it is a good idea to give this ability on everybody on a survival server:

Inspect passwords on mesecons/digiline blocks
Inspect missions/quests stored in node-metadata (with secret goals for example)

(sorry for the criticism, i know you just wanna help)

minertestdude commented 5 years ago

@thomasrudin Ok, so it falls under "excessive data". Then we should include Taose fork instead with updates from stock, because it adds priv checks and degrades reporting for normal user.

No, this should NOT be packaged with default:off, because this tool is very important for normal user - it shows node info to understand which block is used in constructions and shows light info, to improve farming.

Previously on survival server was other (but craftable) node inspection tool, who provided only necessary info, but it was replaced with uncraftable one.

sofar commented 5 years ago

This tool was designed to be an admin tool for debugging mods. I don't want to change that, because in my opinion it reveals too much data and is immersion breaking even if you restrict usage with privileges.

So, a recipe is fine, but by default it shouldn't be craftable.

sofar commented 4 years ago

Closing due to no update with requested changes.