search

minetest-mods / irc

IRC Mod for Minetest
BSD 2-Clause "Simplified" License
43 stars 31 forks source link

Impersonation Glitch #15

Closed nanepiwo closed 9 years ago

nanepiwo commented 9 years ago

Having the nick "IRC" can impersonate others. For example , typing " glitched" from the nick "IRC" will show as "kaeza@IRC glitches" in-game. I believe this can be fixed if messages from this nick are ignored, similarly to how messages from the server are ignored (Ex. If someone from IRC types "MT-Server, players", the people in-game do not see the list.

thatgraemeguy commented 9 years ago

I don't understand where impersonation is coming into this. Are you referring to the in-game chat or IRC chat? Where is the message typed in this scenario? What is the person's IRC nick or in-game name? What is the server's name for IRC purposes?

ShadowNinja commented 9 years ago

@thatgraemeguy IRC:

* kaeza glitches
-- OR --
<IRC> * kaeza glitches

Results in:

* kaeza@IRC glitches

in-game.

nanepiwo commented 9 years ago

Also

<kaeza> glitches.
--- OR ---
<IRC> <kaeza> glitches.

Results in:

<kaeza@IRC> glitches.

in-game.

Note that, on InchraNet, 0gb.us owns the nick "IRC" and has it enforced, but this mod should still ignore messages from that nick.

thatgraemeguy commented 9 years ago

So this scenario revolves around the server using "IRC" as its nick?

Sorry, it wasn't really clear at all.

nanepiwo commented 9 years ago

No, a user on IRC using the nick IRC.

thatgraemeguy commented 9 years ago

They would appear as "IRC@IRC" if you were in game. Who's is being impersonated in this case?

nanepiwo commented 9 years ago

But if that nick types <nanepiwo> Hi that would show as <nanepiwo@IRC> hi. This is because of a feature. If my nick on irc is nanepiwo and I type <Admin> hi that would be <Admin@nanepiwo> hi

ShadowNinja commented 9 years ago

30fa81a3abdabd3382b497b53d7f0c923a058c3f