search

minetest-mods / irc

IRC Mod for Minetest
BSD 2-Clause "Simplified" License
43 stars 31 forks source link

Crash backtrace #19

Closed est31 closed 8 years ago

est31 commented 9 years ago

Hi, I've got this backtrace from a user on irc:

16:50:47: ACTION[ServerThread]: IRC: Connected!
/home/minetest/.minetest/mods/irc/irc/messages.lua:106: bad argument #1 to 'sub' (number expected, got nil)
stack traceback:
        [C]: in function 'sub'
        /home/minetest/.minetest/mods/irc/irc/messages.lua:106: in function 'fromRFC1459'
        /home/minetest/.minetest/mods/irc/irc/messages.lua:13: in function 'Message'
        /home/minetest/.minetest/mods/irc/irc/main.lua:165: in function 'think'
        /home/minetest/.minetest/mods/irc/init.lua:72: in function </home/minetest/.minetest/mods/irc/init.lua:72>
        [C]: in function 'xpcall'
        /home/minetest/.minetest/mods/irc/init.lua:72: in function </home/minetest/.minetest/mods/irc/init.lua:61>
        (tail call): ?
        ...opt/minetest-0.4.12/bin/../builtin/game/register.lua:341: in function <...opt/minetest-0.4.12/bin/../builtin/game/register.lua:329>

They didn't say how to reproduce, just that mods are recent. Also, its unlikely to be a config error, as irc worked previously.

ShadowNinja commented 9 years ago

It seems that the server sent a message with an empty command, but not an empty message (eg, ":server.irc.arpa \r\n"). This seems to violate RFC 1459. Ask the owner to set irc.debug = true to verify this.

yo-we commented 9 years ago

Thanks, est31 for entering the issue. We will activate the IRC debugging.

kaeza commented 8 years ago

Any news?

kaeza commented 8 years ago

@yo-we Is this still valid?