search

minetest-mods / irc

IRC Mod for Minetest
BSD 2-Clause "Simplified" License
43 stars 31 forks source link

`login` is not longer working #24

Closed fireglow closed 8 years ago

fireglow commented 8 years ago

login has ceased to work on our servers.

Minetest server version 0.4.14 (Release) IRC is at commit f98282818db816df22bd6dc1632b7e47e6863a50

Whenever somebody tries to login from IRC (with correct username and password) this gets printed to the console:

2016-06-10_11:04:21.88915 /srv/minetest/world/worldmods/irc_commands/init.lua:63: attempt to call field 'check_password_entry' (a nil value)
2016-06-10_11:04:21.88931 stack traceback:
2016-06-10_11:04:21.88937       /srv/minetest/world/worldmods/irc_commands/init.lua:63: in function 'func'
2016-06-10_11:04:21.88943       /srv/minetest/world/worldmods/irc/botcmds.lua:55: in function 'bot_command'
2016-06-10_11:04:21.88949       /srv/minetest/world/worldmods/irc/hooks.lua:157: in function 'f'
2016-06-10_11:04:21.88955       /srv/minetest/world/worldmods/irc/irc/init.lua:71: in function 'invoke'
2016-06-10_11:04:21.88960       /srv/minetest/world/worldmods/irc/hooks.lua:66: in function 'f'
2016-06-10_11:04:21.88966       /srv/minetest/world/worldmods/irc/irc/init.lua:71: in function 'invoke'
2016-06-10_11:04:21.88971       /srv/minetest/world/worldmods/irc/irc/init.lua:202: in function 'handle'
2016-06-10_11:04:21.88976       /srv/minetest/world/worldmods/irc/irc/init.lua:174: in function 'think'
2016-06-10_11:04:21.88980       /srv/minetest/world/worldmods/irc/init.lua:85: in function </srv/minetest/world/worldmods/irc/init.lua:85>
2016-06-10_11:04:21.88994       [C]: in function 'xpcall'
2016-06-10_11:04:21.88998       /srv/minetest/world/worldmods/irc/init.lua:85: in function </srv/minetest/world/worldmods/irc/init.lua:74>
2016-06-10_11:04:21.89002       ...netest/servers/0.4.14-1/bin/../builtin/game/register.lua:369: in function <...netest/servers/0.4.14-1/bin/../builtin/game/register.lua:349>
fireglow commented 8 years ago

Apologies, firstly, the issue wasn't with IRC, secondly, we've updated the minetestserver binary and it works now, apparently the API call "minetest.check_password_entry" wasn't in there yet.

If somebody stumbles across the same issue: irc_commands switched to using minetest.check_password_entry which was merged to minetest here: https://github.com/minetest/minetest/pull/3859 (after the 0.4.14 release) Solution: Update the minetestserver to include that commit.