search

minetest-mods / irc

IRC Mod for Minetest
BSD 2-Clause "Simplified" License
43 stars 31 forks source link

Add IRC chat to logs #28

Closed taikedz closed 7 years ago

taikedz commented 7 years ago

Add the incoming message form IRC to the log

Allows monitoring all chat through log watcher daemons, and see full chat excerpts

sofar commented 7 years ago

I wouldn't make it use minetest.debug. Instead, use minetest.log("info", ... or something like that.

taikedz commented 7 years ago

Made recommended change

taikedz commented 7 years ago
kaeza commented 7 years ago

LGTM :+1:

@ShadowNinja ?

ShadowNinja commented 7 years ago

It still has an issue with enable_player_part. It's fine if that's fixed.

taikedz commented 7 years ago
ShadowNinja commented 7 years ago

Er, almost right. :-P If the logChat name stuff is removed this is good to go. That doesn't necessarily have to be done by you though...

taikedz commented 7 years ago

*fingers crossed*

kaeza commented 7 years ago

Rebased and squashed version here.

If it's OK with @ShadowNinja, I will push it.

ShadowNinja commented 7 years ago

:+1:

kaeza commented 7 years ago

Merged: https://github.com/minetest-mods/irc/commit/d5ad8ffca46752e37a7327356beaebff37b35f73

Thank you!