search

minetest-mods / irc

IRC Mod for Minetest
BSD 2-Clause "Simplified" License
43 stars 31 forks source link

Refused messages are sent though the irc #33

Closed verymilan closed 7 years ago

verymilan commented 7 years ago

Hi there, i just tested the new spamcontrol feature of Minetest. It turns out that successful refused messages are sent by the IRC mod anyway.

kaeza commented 7 years ago

I can confirm the issue, but IMHO it is a bug feature of the engine.

IRC mod is just blindly processing chat messages; it should be the engine's job to not send filtered messages to mods.

ShadowNinja commented 7 years ago

Definitely an engine issue seeing as we have no way of knowing if a message was filtered -- other than copying all of the spam filtering code into the mod and running it ourselves to see what would happen.

See engine issue: https://github.com/minetest/minetest/issues/4799