[WIP] Colorize IRC messages in-game

minetest-mods / irc

IRC Mod for Minetest

BSD 2-Clause "Simplified" License

43 stars 31 forks source link

[WIP] Colorize IRC messages in-game #46

Closed ClobberXD closed 5 years ago

ClobberXD commented 6 years ago

General IRC chat will be highlighted in a blue-green hue in-game
IRC PMs will be colored purple in-game

Closes #45

sofar commented 5 years ago

Not a bad idea. Maybe show a screenshot? I'd merge this. @kaeza?

ClobberXD commented 5 years ago

I'm thinking of configurable colours for these, instead of the hard-coded ones like in the commits... is it worth implementing?

kaeza commented 5 years ago

:+1:

sofar commented 5 years ago

@ClobberXD yes, totally. A simple lua table that maybe can be loaded from mod_storage would be nice.

ClobberXD commented 5 years ago

@sofar: Why mod_storage? Isn't a couple of key-value pairs in minetest.conf enough?

Also, what should be the default colours for both these settings?

sofar commented 5 years ago

minetest.conf settings are forced on every server on a local machine, and in the long term we'd want the IRC mod settings to be per world and not global. It's a suggestion, and not critical, though.

You can propose a colorscheme.

ClobberXD commented 5 years ago

Is it okay if I go with minetest.conf for now? This could be migrated to mod_storage along with the others...

sofar commented 5 years ago

Fine. Fine, fine

ClobberXD commented 5 years ago

Continued in #52. @kaeza @sofar