search

minetest-mods / mesecons

Mod for Minetest that adds digital circuitry [=Minecraft redstone]
https://mesecons.net
Other
207 stars 121 forks source link

3D mesecon torch #395

Open Wuzzy2 opened 6 years ago

Wuzzy2 commented 6 years ago

I suggest to replace current flat mesecon torches with mesh-based 3D mesecon torches.

MTG offers a model for its own 3D torch.

MoNTE48 commented 5 years ago

With this PR it will be very simple. https://github.com/minetest/minetest_game/pull/2436

Here is an example from my repository: https://github.com/MultiCraft/MultiCraft/blob/master/games/default/files/bluestone/bluestone_torch/init.lua#L1-L17 It seems that this can reduce the torch code by 3 times...

VanessaE commented 5 years ago

MTG's model won't work for Mesecon torches, they are the wrong shape (let alone for power plants or blinky plants, which I used the torch as the basis for).

benrob0329 commented 5 years ago

I think that the current look is fine, it helps to hide the torches if you need to use them to pass a signal through some blocks.

MoNTE48 commented 5 years ago

I think that the appearance could be slightly changed. Now the view of the torches is terrible.

VanessaE commented 5 years ago

Since I somehow got wrangled into being the "graphic design expert" for this project a while back :smiley: (because I designed most of the textures currently in use), I could perhaps make a suitable model if @Jeija and others really want it.

MoNTE48 commented 5 years ago

Anyway, I just did it for my subgame and decided to share it with the community. I do not know how to create models, unfortunately. If mesecons does not require a 3D torch, my PR for minetest_game is probably also not needed.

Desour commented 5 years ago

Imo the mesecons torch looks fine as it is now. A 3D torch would probably look somewhat weird.