minetest-mods / mesecons

Mod for Minetest that adds digital circuitry [=Minecraft redstone]
https://mesecons.net
Other
211 stars 121 forks source link

Sticky piston dragging players #462

Open scr267 opened 5 years ago

scr267 commented 5 years ago

When pulling blocks back to 'open a door' for example, sticky pistons seem to drag a player when it retracts, bringing the player inside a wall, or in some cases even behind it. Is that normal behaviour?

Thanks!

Desour commented 5 years ago

That the player is pulled is intended but he shouldn't end up in a node.

scr267 commented 5 years ago

There are two situations where that effect is rather unintended. On my server I have a space port where I open up a 'door' where basically blocks are pulled out of the way by sticky pistons. If the player is near the blocks they get dragged into the wall. Sometimes even behind the wall and fall into the 'mesecons' wiring in the back.

Another situation is where we tried to make a "trap" that uses 8 pistons to pull the floor out from underneath a player when it is detected. The player simply gets caught in the machinery instead.

Desour commented 5 years ago

Before I write anything else, I should probably ask if you are really sure, that you have the newest mesecons version installed. So, have you? (The version from contentdb might be a bit outdated.)

scr267 commented 5 years ago

I'll get back to you on that one. It's recent but I better double check.

Desour commented 5 years ago

Ahhh, now I see the problem.

Desour commented 5 years ago

>_< mvps pulling has multiple problems.

benrob0329 commented 5 years ago

Pushing/pulling has been a little buggy for a long time (there is a reason I have to use a minecart on fast elevators)

scr267 commented 5 years ago

Thanks both of you for the update. I might give a shot at making a small change.

HybridDog commented 5 years ago

The new add_player_velocity method could be used to push and pull a player. https://github.com/minetest/minetest/commit/cf64054390970f3cf974afb2b174340a3e1da382