search

minetest-mods / mob-engine

Mob Engine (formely Creatures MOB-Engine) is a mod(pack) for Minetest that provides a mob engine and several creatures to the game.
13 stars 5 forks source link

Restructure files and methods #20

Closed BrunoMine closed 6 years ago

BrunoMine commented 7 years ago

Description of the Change

All main functions/methods were separated into files. The commentaries were slightly improved. Code indentation (Tab inserted). Some methods index have also been changed: creatures.register_egg -> creatures.register_spawner_egg creatures.findTarget -> creatures.find_target creatures.dropItems -> creatures.drop_items Some functions become global. creatures.kill_mob creatures.change_hp creatures.knockback

Benefits

Possible Drawbacks

Applicable Issues

lnjX commented 7 years ago

How will we do the copyright in the headers now? You should change/add our copyright, too.

Copyright (C) 2017 Mob API Developers and contributors

BrunoMine commented 7 years ago

Would this be a good standard header?

(1)

--[[
    = Creatures MOB-Engine (cme) =
    Copyright (C) 2015-2016 BlockMen <blockmen2015@gmail.com>
    Copyright (C) 2017 Mob API Developers and Contributors
    ... 
]]

(2)

--[[
    = Creatures MOB-Engine (cme) =
    Copyright (C) 2017 Mob API Developers and Contributors
    Originally by BlockMen <blockmen2015@gmail.com>
    Modified by Developers and Contributors <github.com/minetest-mods/mob-engine/contributors>
    ... 
]]
lnjX commented 7 years ago

Better something like this:

--[[
-= Mob Engine (CME) =-
Copyright (C) 2017 Mob API Developers and Contributors
Copyright (C) 2015-2016 BlockMen <blockmen2015@gmail.com>
... 
]]
BrunoMine commented 7 years ago

Ok, anymore..

BrunoMine commented 7 years ago

I would like to require a little more agility in the analysis of my PR, please. I intend to use mob-engine in my projects, but it's all waiting for it to be resolved. There is a lot of work to be done. I know everyone has their personal tasks, but I'm just asking permission to continue. After the acceptance of this PR I will be initiating the detailed discussion about the syntax change and the mod name.

BrunoMine commented 7 years ago

I would like to know why we stopped working on this

lnjX commented 7 years ago

I think it's probably fine, to merge this. :+1:

BrunoMine commented 7 years ago

I am waiting for 100 days for approval. I'm afraid I can not make it to 120 year old to see the first stable version of that.

sofar commented 6 years ago

@BrunoMine @Diogo-Gomes @mahmutelmas06

you all have merge privs, right? why is this still sitting here?

BrunoMine commented 6 years ago

We already have agreed that at least 2/3 approvals (and 3/3 for big changes, which is the case here) are required to merge. What was done just now. Maybe we'll need to change this, or this project will never progress.

lnjX commented 6 years ago

The main problem is actually that I'm currently not interested in minetest development, so I won't be active here, too.

BrunoMine commented 6 years ago

So I suggest you approve changes from developers that are active for now, in the future you can make or suggest corrections. But you have to make a choice just now or the project will be too prolonged. I've had many improvements to make, but I can not remember where I stored it anymore.