minetest-mods / moreblocks

More Blocks
https://content.minetest.net/packages/Calinou/moreblocks/
zlib License
45 stars 67 forks source link

Minor issue causing warnings in MT 5.5.0 with texture alpha clipping #187

Open Baigle opened 2 years ago

Baigle commented 2 years ago

Posting because I have thousands of messages in my debug.txt about these, and I now see them after I allowed warning-level messages in chat. It won't be an issue until they require it to be set in the future.

WARNING[Main]: This warning can be a false-positive if unused pixels in the texture are transparent. However if it is meant to be transparent, you MUST update the nodedef and set use_texture_alpha = "clip"! This compatibility code will be removed in a few releases.

The affected textures are:

"default_glass.png^[colorize:#828282" of moreblocks:coal_glass_cube "default_glass.png^[colorize:#828282" of moreblocks:coal_glass_doublepanel "default_glass.png^[colorize:#828282" of moreblocks:coal_glass_halfstair "default_glass.png^[colorize:#828282" of moreblocks:coal_glass_micropanel "default_glass.png^[colorize:#828282" of moreblocks:coal_glass_microslab "default_glass.png^[colorize:#828282" of moreblocks:coal_glass_nanoslab "default_glass.png^[colorize:#828282" of moreblocks:coal_glass_panel "default_glass.png^[colorize:#828282" of moreblocks:coal_glass_thinstair "default_glass.png^[colorize:#DEDEDE" of moreblocks:iron_glass_cube "default_glass.png^[colorize:#DEDEDE" of moreblocks:iron_glass_doublepanel "default_glass.png^[colorize:#DEDEDE" of moreblocks:iron_glass_halfstair "default_glass.png^[colorize:#DEDEDE" of moreblocks:iron_glass_micropanel "default_glass.png^[colorize:#DEDEDE" of moreblocks:iron_glass_microslab "default_glass.png^[colorize:#DEDEDE" of moreblocks:iron_glass_nanoslab "default_glass.png^[colorize:#DEDEDE" of moreblocks:iron_glass_panel "default_glass.png^[colorize:#DEDEDE" of moreblocks:iron_glass_thinstair "default_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_glass_cube "default_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_glass_doublepanel "default_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_glass_halfstair "default_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_glass_micropanel "default_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_glass_microslab "default_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_glass_nanoslab "default_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_glass_panel "default_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_glass_thinstair "default_obsidian_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_obsidian_glass_cube "default_obsidian_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_obsidian_glass_doublepanel "default_obsidian_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_obsidian_glass_halfstair "default_obsidian_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_obsidian_glass_micropanel "default_obsidian_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_obsidian_glass_microslab "default_obsidian_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_obsidian_glass_nanoslab "default_obsidian_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_obsidian_glass_panel "default_obsidian_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_obsidian_glass_thinstair "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_cylinder "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_cylinder_horizontal "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_element_cross_double "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_element_cross "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_element_edge_double "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_element_edge "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_element_end_double "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_element_end "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_element_straight_double "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_element_straight "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_element_t_double "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_element_t "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_oblate_spheroid "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_onecurvededge "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_pyramid "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_slope_edge "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_slope_edge_upsdown "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_slope "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_slope_inner_edge "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_slope_inner_edge_upsdown "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_slope_lying "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_slope_upsdown "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_sphere "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_spike "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_stick "moreblocks_cactus_checker.png" of moreblocks:cactus_checker_technic_cnc_twocurvededge "moreblocks_clean_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_clean_glass_cube "moreblocks_clean_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_clean_glass_doublepanel "moreblocks_clean_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_clean_glass_halfstair "moreblocks_clean_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_clean_glass_micropanel "moreblocks_clean_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_clean_glass_microslab "moreblocks_clean_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_clean_glass_nanoslab "moreblocks_clean_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_clean_glass_panel "moreblocks_clean_glass.png^moreblocks_trap_box_glass.png" of moreblocks:trap_clean_glass_thinstair "moreblocks_clean_glass.png" of moreblocks:clean_glass_cube "moreblocks_clean_glass.png" of moreblocks:clean_glass_doublepanel "moreblocks_clean_glass.png" of moreblocks:clean_glass_halfstair "moreblocks_clean_glass.png" of moreblocks:clean_glass_micropanel "moreblocks_clean_glass.png" of moreblocks:clean_glass_microslab "moreblocks_clean_glass.png" of moreblocks:clean_glass_nanoslab "moreblocks_clean_glass.png" of moreblocks:clean_glass_panel "moreblocks_clean_glass.png" of moreblocks:clean_glass_thinstair

Thanks for your time.

Calinou commented 2 years ago

For opaque textures, which value should be used for use_texture_alpha? Should it be set to false explicitly or should the line be removed entirely?

fluxionary commented 2 years ago

The approach I've taken in #191 is to copy the use_texture_alpha from the parent node by default, and allow individual registration to override that if desired. This puts the resolution of these warnings into other modmakers' hands. IMO There isn't more of a solution needed in the context of stairsplus itself.

oh this is about moreblocks itself, not stairsplus... sure i'll fix this