search

minetest-mods / moreblocks

More Blocks
https://content.minetest.net/packages/Calinou/moreblocks/
zlib License
45 stars 65 forks source link

Some adjustments to crafts might not be future-compatible #192

Open Lazerbeak12345 opened 2 years ago

Lazerbeak12345 commented 2 years ago

Hey there, we've been reviewing your mod in this issue in the WhyNot project: https://github.com/minetest-whynot/whynot-game/issues/25

There's a few concerns, but I'll just post em one-at-a-time so you, the developer of this project, can choose to accept or reject any of these suggestions on their own. They might not come in very fast. The three of us at WhyNot are somewhat busy.

And yes, I'd be willing to send you a PR with a solution for any of these issues.

These crafts are the ones I'm concerned about. To quote myself from the issue I linked,

  • Changes quantity of default:sign_wall craft to old + 1
  • Changes quantity of default:paper craft to old * 4
  • Changes quantity of (re) carts:.*rail and default:.*rail craft to old + old/2

The concern is mostly that if another mod chooses to make a modification to these recipes like moreblocks does, it might not result in the intended value. This could also be problematic if the mod changes their recipe output.

fluxionary commented 2 years ago

as i'm writing this, i'm half asleep, but i fear i'll forget it in the morning if i don't reply now.

my PR against moreblocks removed some recipe changes that were forced if you used moreblocks. such changes were amongst the most minor features provided, and i deemed such changes to be more fitting to a specific server's overrides, vs. trying to be opinionated about balancing how many items should result from certain crafting recipes. if you want a separate mod that'll make everything "exactly like it was before", i could do that, but every server operator i've spoken to already has custom mods to balance and integrate the minetest mod ecosystem.

fluxionary commented 2 years ago

to be more precise, sure, i'll create a mod that overrides the recipes the way they were overridden before, but it'll be a completely separate mod.

Calinou commented 2 years ago

to be more precise, sure, i'll create a mod that overrides the recipes the way they were overridden before, but it'll be a completely separate mod.

I think this is the best course of action too. Ideally, this mod should be available before More Blocks 3.0.0 is formally released, so that I can link to it in the release notes.

fluxionary commented 2 years ago

I added a default-off option to enable those old recipes:

https://github.com/minetest-mods/moreblocks/pull/191/commits/5ae6dfeb342c57edf210effc207e7a9947f091a2

Lazerbeak12345 commented 2 years ago

Awesome! To be completely fair, these crafting adjustments also broke another WhyNot rule, in that they could be seen as "taking over the game." @fluxionary 's PR would fix that issue in the context of WhyNot, and if we take advantage that it is in a seperate mod (which can be disabled or simply excluded) then that also fixes the other problem.

Lazerbeak12345 commented 2 years ago

Linking afore-mentioned pr to link all the things: #191