search

minetest-mods / moreblocks

More Blocks
https://content.minetest.net/packages/Calinou/moreblocks/
zlib License
45 stars 67 forks source link

Fix name collision between moreblocks and stairsplus code. #87

Closed ashtrayoz closed 6 years ago

ashtrayoz commented 7 years ago

moreblocks/stairsplus generates stuff with a set of suffixes, including "_alt", "_alt_1", etc. But moreblocks already defines a block named moreblocks:stair_split_stone_tile_alt Crafting with a single moreblocks:stair_split_stone_tile_alt has two conflicting outputs. One is registered from moreblocks/crafting.lua, one is from stairsplus.

This change renames the base block in moreblocks to "split_stone_tile_other", which resolves the crafting problem. It will break existing worlds.

There are other ways this could be fixed, but they will probably break existing worlds as well. More ideas are welcome.

Calinou commented 7 years ago

Maybe add an alias, so that existing worlds aren't broken by this change?

sofar commented 6 years ago

Needs a rebase, please?

fozolo commented 6 years ago

A picture to clarify the original issue. screenshot_20171230_102014

This no longer happens because split_stone_tile_alt was aliased to checker_stone_tile. However the aliases for the cut versions were missed.

sofar commented 6 years ago

107 replaced this.