search

minetest-mods / moreores

More Ores
https://content.minetest.net/packages/Calinou/moreores/
zlib License
26 stars 30 forks source link

Unable to mine ores in mtg since commit `4f7ec3b` #56

Closed eris667 closed 10 months ago

eris667 commented 10 months ago

After updating today I was no longer able to mine silver ore, tried with mese and diamond pickaxe. (unbreakalbe block via pickaxe)

Rolled back to previous version and the issue resolved

Niklp09 commented 10 months ago

yep, caused by https://github.com/minetest-mods/moreores/commit/4f7ec3b3ae7962b567335852becf729cda37d9f8 more precise, by the merge_tables() function (the mcl groups are added, but the mtg group is dropped. Sincd the function doesn't work recursively).

Calinou commented 10 months ago

This is a regression from https://github.com/minetest-mods/moreores/pull/55. cc @JamesClarke7283

JamesClarke7283 commented 10 months ago

Okay, will take a look now.

JamesClarke7283 commented 10 months ago

yep, caused by 4f7ec3b more precise, by the merge_tables() function (the mcl groups are added, but the mtg group is dropped. Sincd the function doesn't work recursively).

Thanks for the hint! helped me solve it much faster.

VAggrippino commented 10 months ago

❤ I wish commercial, paid software products were as well maintained as mods for Minetest.

For example, a recent update for Bitwarden (password manager) causes a continuous flood of debugging messages in the browser's console. Their response was effectively We're sorry about that. We'll fix it for our next release in three weeks