ERROR ver 5.2.0 Release

Imk-MT commented 4 years ago

2020-04-07 05:32:44: ERROR[Main]: ModError: Failed to load and run script from /home/imk/minetest/bin/../mods/nether/init.lua:
2020-04-07 05:32:44: ERROR[Main]: Unknown node: stairs:stair_cobble
2020-04-07 05:32:44: ERROR[Main]: stack traceback:
2020-04-07 05:32:44: ERROR[Main]:       [C]: in function 'get_content_id'
2020-04-07 05:32:44: ERROR[Main]:       /home/imk/minetest/bin/../mods/nether/mapgen.lua:78: in main chunk
2020-04-07 05:32:44: ERROR[Main]:       [C]: in function 'dofile'
2020-04-07 05:32:44: ERROR[Main]:       /home/imk/minetest/bin/../mods/nether/init.lua:59: in main chunk

ERROR ver 5.2.0 Release 5.2.0-dev-0df646e-dirty worked well

Treer commented 4 years ago

This appears to be caused by new behavior in minetest.get_content_id() not finding the node after moreblocks mod sets an alias of "stairs:stair_cobble".

I suspect aliases aren't supposed to break get_content_id() like this - reported it here

trungus commented 4 years ago

Hi guys I found a workarround for this issue, you can replace the call for "minetest.get_content_id" for local function like this

nether.get_content_id = function(name)
    name = minetest.registered_aliases[name] or name
    return minetest.get_content_id(name)
end

this code work fine in my home server, I have the same problem with many mods and this snippet solve it.

Best Regards

Treer commented 4 years ago

sfan5 has merged a fix for this into Minetest, nether should run now on the nightly builds

mckaygerhard commented 2 years ago

pufff the fix works only for recent engines.. but most servers does not work and cannot upgrade so fast.. why developers are so closed respect the players and users !!! that's why MT 5.X has the minor market shared of all voxel games

Treer commented 2 years ago

the fix works only for recent engines

This bug was only introduced in a recent engine. Can you be more specific, what error are you seeing and on which version of Minetest?

mckaygerhard commented 2 years ago

the fix works only for recent engines

This bug was only introduced in a recent engine. Can you be more specific, what error are you seeing and on which version of Minetest?

i used 5.2 so .. and i will not upgrade 34 mods .. to 5.5 can you developers stop being obtuse and place the code that @trungus report in https://github.com/minetest-mods/nether/issues/19#issuecomment-612211177 !

now i understand why 5.X its being LESS used and multicraft gain so marked

Treer commented 2 years ago

When someone is uninterested in "recent engines" and grinds an axe about how nobody uses MT 5.x, it comes across like they are running 4.x, so I needed to know if an 'Unknown node' error had crept into in nether mod on 4.x, or whether this was the same MT engine bug in 5.2.0 (a bug which the MT devs had swiftly corrected).

I've put the MT 5.2.0 workaround into a modern version of nether here: https://github.com/Treer/nether/archive/refs/heads/bugfix/get_content_id-2022.zip

mckaygerhard commented 2 years ago

When someone is uninterested in "recent engines" and grinds an axe about how nobody uses MT 5.x, it comes across like they are running 4.x, so I needed to know if an 'Unknown node' error had crept into in nether mod on 4.x, or whether this was the same MT engine bug in 5.2.0 (a bug which the MT devs had swiftly corrected).

we do not need so many cell brains to check the list of minetest servers, most are multicraft clients and phones..

facts are facts.. and that zip it's another way to said: "i will not do that" but more polite.. thanks in any ways, sad true for a great game, i recently chekc the minetest-mod manifiest.. soo geek and never close to gamers..

I've put the MT 5.2.0 workaround into a modern version of nether here: https://github.com/Treer/nether/archive/refs/heads/bugfix/get_content_id-2022.zip

minetest-mods / nether

ERROR ver 5.2.0 Release #19