minetest-mods / nether

Nether mod for Minetest
https://forum.minetest.net/viewtopic.php?f=11&t=5790
19 stars 26 forks source link

Add nether based tools to mod #31

Closed lortas closed 3 years ago

lortas commented 3 years ago

Just a first try, to have tools build out of nether. There is space for improvement. :-)

SmallJoker commented 3 years ago

Looks good. @Treer - opinions?

Treer commented 3 years ago

I like to have newly introduced game elements optional in the settings, in hope of aiding anyone trying to build/tune games or custom servers, so I'd suggest a Nether Tools setting that defaults to true. That's not a demand though, as it's unclear to me how helpful/used such settings really are, and could be added later if someone wanted it. If a setting were added then nether_compressed could go in nodes.lua and not be affected.

Also update the attributions in the readme to cover the new assets.

I'm no judge of tool balance - happy for whatever lortas wants.

(hoping to get some time over Christmas to catch up with that other PR)

Treer commented 3 years ago

I had a play with this, and "Nether Compressed" seemed like an odd description for a node, how about

Again, just a comment, not a requirement.

lortas commented 3 years ago

With "Nether Compressed" I tried to be conform with the following nodes from "moreblocks".

But I also like the term "Enriched Netherrack". The intention of this node was to gather nether ore. And combing nine Netherracks to "Enriched Netherrack", would enrich the containing nether.

lortas commented 3 years ago

By the way, the proposed textures are just images from "default" and "moreblocks" where I have changed the colors. If it is okay for everyone, just use the same owner/copyright/copyleft/... the origin had. I do not claim anything.

Treer commented 3 years ago

"Compressed Netherbrick" or "Compressed Netherrack" would be the way to go if you wanted to follow moreblocks node names like "Compressed Cobblestone".

"Nether Compressed" sounded odd to me because the word order was reversed and I think of "Nether" as a location or a mod or an adjective, rather than a brick or stone type like Netherrack or Nether brick.

the proposed textures are just images from "default" and "moreblocks" where I have changed the colors. If it is okay for everyone, just use the same owner/copyright/copyleft/... the origin had. I do not claim anything.

Don't worry about the licensing then, I can probably sort it out - I've been meaning to update the readme anyway.

lortas commented 3 years ago

Ok, and while the new node is crafted out of Netherbrick, we should name it "Compressed Netherbrick". This texture may better fits the new name: nether_brick_compressed

Treer commented 3 years ago

I can merge this now if you're ready

lortas commented 3 years ago

from my side, it is ready to merge.