minetest-mods / nether

Nether mod for Minetest
https://forum.minetest.net/viewtopic.php?f=11&t=5790
19 stars 26 forks source link

Not sure if this is an issue, tried the mod but it dried up the nearby oceans #54

Closed mightyjoe781 closed 2 years ago

mightyjoe781 commented 2 years ago

Server : multicraft mapgen : v7


Installed the mod correctly. All nether stuff works fine. Issue is where-ever i marked the spawn was surrounded by a large ocean. Now after installing mod that ocean is being replaced by air as i move around the ocean. Is this a bug or expected behaviour ?? or Mapgen is doing something nasty with oceans/water bodies on surface ?

Treer commented 2 years ago

I haven't used multicraft or tested against it, is it possible they're not 100% compatible with Minetest 5?

Nether mapgen won't affect areas that have already been emerged (unless you've set the backend database to dummy so that the land is regenerated every time the server starts), so the first thing I'd do is make absolutely sure nether is the cause - what happens to oceans if you disable nether (and only nether)?

If it is nether, you could try commenting out this line: https://github.com/minetest-mods/nether/blob/master/mapgen.lua#L189

That line affects cave water in the nether biome, so wouldn't normally affect the ocean, but perhaps multicraft implements it oddly?

mightyjoe781 commented 2 years ago

Hello thanks for your response from what I tested found out there was another mod/patch that was registering an ABM for removing water from nether but it was behaving weirdly (there were correct ranges of y given) and removing water on surface.