search

minetest-mods / player_monoids

Monoidally-managed Minetest state modifications
Other
12 stars 8 forks source link

Use mod.conf for dependencies and description #5

Closed Panquesito7 closed 5 years ago

Panquesito7 commented 5 years ago

Deletes deprecated description.txt. This will only work with MT/MTG 5.0.0 and above.

raymoo commented 5 years ago

Any reason for removing newlines at the end of every file? Ending every line with a newline is the POSIX standard for text files.

Panquesito7 commented 5 years ago

I don't wan't to be rude, but, what's wrong with having all changes in a single commit?

Any reason for removing newlines at the end of every file?

IMHO, they're useless; I can un-do those changes if you wan't.

raymoo commented 5 years ago

I don't wan't to be rude, but, what's wrong with having all changes in a single commit?

Each logical change should be its own commit so that they can be dealt with independently by operations such as cherry picking or reversions. This also includes bisection, where it will be harder to determine the cause of a bug if you land on a commit with multiple changes in it.

It also makes it easier to browse commits. Not having multiple changes means needing to cram less information into the commit message, which (IMO) makes it easier to read when viewing the commit log. Having just the file changes for one thing also makes it faster to find the files relevant to whatever feature / bug fix / other logical change you want to examine.

IMHO, they're useless; I can un-do those changes if you wan't.

Like I mentioned earlier, newlines at the end of each line is part of the POSIX standard and most editors on Linux or Mac will automatically add them to make valid text files. Removing will result in thrashing where the next change made by someone on a POSIX system will re-add the newlines.

Panquesito7 commented 5 years ago

@raymoo, I'll create a new PR and fix all those issues.