Closed BlockAndPixelAge closed 1 month ago
@SmallJoker
Ehhhh, where do I find the correct tutorial, if I try to search for something it's not really what I'm looking for?
Do I need to do something by commit here in the pull request,that is beside the conversation tab?
And the Arm for 1.8 has now a Layer, or more 3d Layer, before it was layerless and it showed the textures of the left arm.
@SmallJoker
Sorry to say this but, I don't understand the tutorials I find. >A<
@SmallJoker
I'm too incompetent for the commit author change. Don't understand tutorials in text or video format. If I transfer ownership of the repository, would that close the pull request or would it stay open?
I'm too stupid to understand the tutorials.
Definitely not amateur friendly, which I am.
@SmallJoker
I give up, I don't understand the tutorials for changing the commit author.
Guess I will close the pull request and wait that someone who knows how to do it, will do the pull request.
1. Why is `skinsdb_hand_18.b3d` 200 times larger than the previous version?
The outer skin layer has been made 3D, which means that eache pixel is now a 3D cube. So the 3D model went from 24 tris to 2700 tri.
@BlockAndPixelAge
# modify the commit
git commit --amend --author="Linus Torvalds <linus@torvalds.com>"
# overwrite your branch to use the new commit
git push --force
@Lemente
Thank you for clarifying. That does explain the size difference. However, I am yet not sure why this is needed. Unfortunately, precision issues might cause visual artifacts like reported here: https://github.com/minetest/minetest/issues/4912 . Hence, if it would be possible to use fewer adjacent polygons, this could largely be avoided on such affected hardware. That aside, it might also perform slightly better on ancient hardware (but that's not my concern). (EDIT: does not apply. There is no automatic vertex optimization for models.)
@SmallJoker
I don't see how to do it here directly in Github, and from what I roughly somehow but not really understand from Tutorials, is, that I somehow need to have Github Desktop (yay, downloading extra software -.-) and that it's somehow possible to do that even after a pull request.
And I use the free option of Github
Comment written on smartphone.
@SmallJoker @Lemente
Bad news and bad news.
So there are for now only 2-3 options.
At the moment you can't count on me, because of what happened to my pc. >A<
@SmallJoker I close the pull request, because no PC, and not understanding the tutorials at all. Someone who knows how to change the commit author, should do it.
Sorry.
As mentioned by @Lemente that someone needs to do the pull request.
https://github.com/minetest-mods/skinsdb/issues/99#issuecomment-2226860384
Here a pull request, with the first person arm fix, while the arm for 1.8 having a 3d layer, done by Lemente.
This is my first pull request that I ever did, so the only thing I don't know how to do is, how to edit the readme to add Lemente to the credits for the updated 1.8 hand.
Hope that I don't count as a contributor.