3d_armor mt_0.5.0-dev support

[tacotexmex]

With 3d_armor mt_0.5.0-dev branch the player stands halfway through the ground.

[bell07]

I did not tested mt_0.5.0-dev, heard about some changes for player but do not know the details.

Do you use 0.5.0-dev Minetest? Does 3d_armor mt_0.5.0-dev work for you without skinsdb?

I know the issue I need to port some functions to "player_api" if 0.5. is there.

Agree, the skinsdb is not ready for 0.5.0 yet, as the most of my mods. I use the stable engine only so I can fix it if 0.5.0 is released. But Patching ideas and Pull-Requests welcome

One try: Please replace the "skinsdb/models/skinsdb_3d_armor_character.b3d" file by the file 3d_armor_character.b3d (from 3d_Armor mt_0.5.0-dev). Just copy from 3d_armor and rename / replace the file. I use the models from @stujones11 since 1.8-skins support.

[SmallJoker]

After these months of development I actually don't remember when the player collision box and its model got changed to the new 0m offset -- however, previously the model had its origin at 1m above ground, which is now at exactly 0m (feet position). Just a hit & miss idea: check whether player_api exists. If it exists, use the new model , if not: keep the current existing one to provide 0.4.?? compatibility.

[bell07]

@SmallJoker , is the player_api/models/character.b3d useable for 3d_armor and 1.8er Skins? Or I still need to use the 3d_armor model?

[bell07]

Just for reference, for player_api I proposed some changes for better skins support: https://github.com/minetest/minetest_game/issues/1965#issuecomment-382336806

[SmallJoker]

@bell07 Because it's skinsdb which seems to specify the used player model, the 3d_armor model with 1.8 skin support should be used to ensure the armor compatibility. player_api is the minimal model, which supports neither armor nor extended skins.

[bell07]

Initial work done in https://github.com/bell07/minetest-skinsdb/tree/mt_0_5_dev @tacotexmex , can you please test? I do not have 0.5 for testing (I am stable user)

[tacotexmex]

Will test, thanks alot for this effort!

[tacotexmex]

The issue persists I'm afraid.

[bell07]

Do you use minetest_game-0.5-dev or have the player_api mod? The "if" check for player_api to decide which implementation should be used

[tacotexmex]

I use the latest engine with the latest minetest_game. It has the player_api mod.

[bell07]

Ok, now compiled 0.5-dev to test this issue ...

Played arround and found out, if you use playeranim mod, you need to set

player_model_version = default_character_v3

to you minetest.conf to get it working. No changes necessary in skinsdb this way.

Without playeranim my last changes does work with 3d_armor and without. Ok, with 3d_armor I nab wrong model file, updated to the right one now.

Pls. noe the current mt_0_5_dev is a temporary solution till https://github.com/minetest/minetest_game/pull/2122 is completed, so I do not merge them to minetest-mods

[tacotexmex]

I can now also get it working properly with 3d_armor(mt_0.5.0-dev)+skinsdb. However, I also use multiskin mod so with this mod activated as well the bug persists. But that's an issue with multiskin, right?

[bell07]

I did not tested the skinsdb and multiskin together because I just did not understand the multiskin. So asume the mods are not compatible and maybe redundant. Most usefull things I seen in multiskin I ported to skinsdb.

What is your use-case? Why you need the multiskin?

[tacotexmex]

I added it because I thought that I needed it for the multilayered skin support. (1.8)

[bell07]

Yea, in April I ported the 1.8. skins support from multiskin to skinsdb in a way the "master" 3d_armor can be used. So just place the 1.8er Skins to the skinsdb textures folder. I recommend in addition to create preview files and meta-files to be shown in inventory.

[tacotexmex]

I see! That’s great, I’ll just remove multiskin then.

Will mods depending on multiskin work by changing the dependency to skinsdb too perhaps? 😬

[bell07]

I let the issue open till an acceptable 0.5 solution is in minetest-mods

Will mods depending on multiskin work by changing the dependency to skinsdb too perhaps? 

It is full incompatible oO. I do not know mods depending on multiskin. Which one do you mean?

[tacotexmex]

I’m thinking of stujones11/clothing.

[bell07]

I’m thinking of stujones11/clothing.

was long time on my todo list, started working on them now ;-)

[bell07]

Discussion about clothing support in https://github.com/minetest-mods/skinsdb/issues/15

[bell07]

The clothing support is merged to master now, the bell07/skinsdb/mt_0_5_dev is rebased against them. Stu merged the https://github.com/stujones11/clothing/pull/11 @tacotexmex so just update both mods and use clothing without multiskin ;-)

For me the clothing support is still missed in smart_inventory, so it's the next task on my list for now

[tacotexmex]

Thank you, that’s very helpful!

[bell07]

@tacotexmex , did you get managed to get the 1.8 skins working on Minetest-0.5-dev? I tested my changes again today and got crapy skin :-(

[bell07]

Ok, fixed now. Got right models from Stu

[Poikilos]

With 3d_armor mt_0.5.0-dev branch the player stands halfway through the ground.

Hmm...this is still happening in 5.0.0-dev compiled yesterday, without any mods beyond minetest_game. @bell07 still halfway underground on your fork as well. Are we calling it the same issue, making a separate issue, or waiting on https://github.com/minetest/minetest_game/pull/2122 considering conversation above? I would love to be able to use this mod before that but understand if not worth it if PR is to be merged.For testing, I have an easy 5.0.0-dev update try this linux shell script:

wget -O install-minetestserver-git-all-backends.sh https://github.com/poikilos/EnlivenMinetest/blob/master/install-minetestserver-git-all-backends.sh
chmod +x install-minetestserver-git-all-backends.sh
./install-minetestserver-git-all-backends.sh both

(or if you only want client and not server, put client instead of both)

[bell07]

The issue should be fixed in my fork - mt_0_5_dev Branch. To be sure you use the right version please check if your copy contains the models/skinsdb_3d_armor_character_0_5.b3d file.

You can use the next link to download the right version: https://github.com/bell07/minetest-skinsdb/archive/mt_0_5_dev.zip

[wziard]

While the player doesn't stand halfway through the ground (an improvement for sure) in your fork, I don't see the armor when worn. Should it work?

Also, the normal player model looks like there are tiny gaps along the edges.

[bell07]

@wziard, it should work. Now I updated the mt_0_5_dev merging new changes from master. Please try again with the new version. If it still does not work, same question as for character_creator: which other skins-related mods from which do you use?

Other way is to use mods from https://github.com/bell07/minetest-player_api_modpack modpack. The pack contains 2x skins selectors: "skinsdb5" is based on "skinsdb". "skins" is based on "simple skins" you can try too. All other mods needs to replace the "original" mods. Because of the modpack the mt_0_5_dev branch is not well maintained.

[wziard]

It still doesn't work.

I use 3d_armor and character_creator. Bot the latest versions from git.

edit: I use the MT_0.5.0_dev branch from 3d_armor. From https://github.com/stujones11/minetest-3d_armor.git

and character_creator master branch from minetest-mods/character_creator

[ghost]

Guys, MT5 has released and my player model is still drowned in a node((

I've no blender skills so I request it again.

[bell07]

Can you pls check if the version from my fork mt_0_5_dev branch does work for you? If yes I prepare the push to minetest-mods

[ghost]

Checked it. It works with 1.0-er skins, but 1.8-er are buggy.

[bell07]

After I wrote the comment I updated the branch. I fixed this issue in the past but the change seems to be lost. So I placed again the right model file. Please check if you have the latest version from the branch

[ghost]

It works, but not with armor3d.

With armor:

[bell07]

I checked my old messages in forum and found (again) the right models. Thanks once again to stu

@TillCoyote pls. next try

[ghost]

@bell07 you made it cool, thanks!

Also, it probably have to support "clothing" mod but I need it no.

[bell07]

done in #24