search

minetest-mods / skinsdb

Player skin mod, supporting unified_inventory, sfinv and smart_inventory
27 stars 41 forks source link

GPLv3 and CC-BY-NC-SA are incompatible licenses. #19

Closed rrigby closed 6 years ago

sofar commented 6 years ago

update_skins_db.sh is the only problem. We should remove it.

sofar commented 6 years ago

@bell07 I agree this is an issue, and we should resolve it.

SmallJoker commented 6 years ago

Since almost nothing is left over from cornernote's original code it would also be possible to agree a license change of the project - a license which is compatible with CC-BY-NC-SA so that the update script can be kept.

bell07 commented 6 years ago

Which licenses are compatible to CC-BY-NC-SA?

I think we should remove the updater. The issue is the both other updaters are buggy, and I cannot fix them because of no Python or C# skills.

Since the skinsdb supports MC-1.8 compatible skins, available on many www-sites and online-skins-editors, I do not use the updater anymore byself.

In long-term subsequent project skinsdb5 all updaters are already removed.

Maybe the updaters should be an own project with own license

bell07 commented 6 years ago

Created pull request that removes all updaters. The "Windows" Updater did provided Newtonsoft.Json.dll that is not free. The Python updater is broken for me.

But I ask for confirm / second-approve this PR before I merge it

sofar commented 6 years ago

Which licenses are compatible to CC-BY-NC-SA?

shell scripts like this should just be ISC or MIT, only. There really is nothing special about them. GPL-3.0 if you're wild.

bell07 commented 6 years ago

Now I read the license. To honor the license I need to say I modified the script in 0ed683210e526edcdb931e8c136f87473d2e2441 and 11c39cd149f0ebd5df599e2b7d8148d3306055ee. The current copy is "modified work". Good or bad from license point of view?

sofar commented 6 years ago

bad, since, at that time, the -NC license applied to that file.

Best to write a simple new scraper. Even better to just temporarily delete the version right now to avoid further issues.

bell07 commented 6 years ago

Updaters removed. New updaters requested in #21