Rework private skins handling

minetest-mods / skinsdb

Player skin mod, supporting unified_inventory, sfinv and smart_inventory

28 stars 41 forks source link

Rework private skins handling #2

Closed bell07 closed 6 years ago

bell07 commented 6 years ago

add skin:is_applicable_for_player(playername) method
add skins.get_skinlist_with_meta(key, value) function
hide private skins in unified_inventory since not supported (#1)
check player assignment in skins.assign_player_skin() + inherited to skins.set_player_skin() (bug-part in #1)

bell07 commented 6 years ago

Is my second approval enough for merge or should second approval be from minetest-mods team member? It is my first change for mod transferred to minetest-mods

SmallJoker commented 6 years ago

In theory, this approval process is not required if you are the previous mod owner/author, which means you can merge (almost) everything you want. http://irc.minetest.net/minetest-hub/2018-01-07#i_5193313 However, I'm happy to see the changes as PRs to be able to review them, but that may sometimes just be too much effort for a small change ;)

bell07 commented 6 years ago

Thank you! I like to create PR because of sometimes my hash changes gets more quality after review by other people. I added a last change: support for "in_inventory_list" attribute that allow to have skins allowed to be applied but not visible in inventory skins list. Should be useful for wardrobe-like mods with skins not in inventory.

By the way, can you look to the https://github.com/minetest-mods/character_creator/pull/13? I do not have permission for them. Without the change the player can see the other-player skins in inventory because the "playername" is not filled.